Log grpc write error #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 but it actually got changed back to plain proto-over-HTTP by Tom a while ago, but some gRPC naming stuck around. Maybe rename that and the error message? |
|
I couldn't think of a good name, so I deleted the type and shuffled things around a bit. @juliusv, let me know what you think. |
|
👍 though the whole thing should be refactored again to use But maybe in another PR... |
This was referenced Sep 30, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a production incident where we couldn't readily identify the cause of 500s because we weren't logging them. This hopefully fixes that.