Improve bucket index loader to handle edge cases #3717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While rolling out the bucket index in our of our clusters I've noticed that we have some tenants with rules but not remote writing the cluster (or started very soon to remote write so their blocks haven't been uploaded to bucket yet). Since there are no blocks in the bucket, their bucket index doesn't exist and this leads the
bucketindex.Loaderto continuously try to load their bucket index.In this PR I'm proposing 3 changes that should relief the pressure when such edge case happens:
cortex_bucket_index_load_failures_totalonErrIndexNotFounderror (we already didn't do in the background check)ErrIndexNotFound, update it everyUpdateOnStaleIntervalinstead ofUpdateOnErrorIntervalWhich issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]