Reduce flakiness on chunk flush tests #4386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thinking was: we are flushing every 20ms, so wait 40ms to be sure that one cycle has happened. However if you log the times at which things happen, it is fairly common to see 100ms delay on the flush ticker. So wait a lot longer to be sure. Also close down the ingester that we created for the test, and improve the error message on failure. Signed-off-by: Bryan Boreham <[email protected]>
pstibrany
approved these changes
Aug 17, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
The thinking was: we are flushing every 20ms, so wait 40ms to be sure that one cycle has happened. However if you log the times at which things happen, it is fairly common to see 100ms delay on the flush ticker. So wait a lot longer to be sure. Also close down the ingester that we created for the test, and improve the error message on failure. Signed-off-by: Bryan Boreham <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running ingester tests locally I would get occasional failures in these tests.
The thinking was: we are flushing every 20ms, so wait 40ms to be sure that one cycle has happened.
However if you log the times at which things happen, it is fairly common to see 100ms delay on the flush ticker.
So wait a lot longer to be sure.
Also close down the ingester that we created for the test, and improve the error message on failure.
Checklist
CHANGELOG.mdupdated