Fixed flaky TestMultitenantAlertmanager_SyncOnRingTopologyChanges #4418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
fix-flaky-alertmanager-test
branch
from
4cb6795 to
f7ef3a8
Compare
pstibrany
approved these changes
Aug 12, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…rtexproject#4418) Signed-off-by: Marco Pracucci <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Most CI flaky failures are due to
TestMultitenantAlertmanager_SyncOnRingTopologyChanges, so I took some time to investigate it. The reason of the flakyness is that whenMultitenantAlertmanager.run()is started, the ring change done by the test may have already happened and so the ring state change will not be detected byrun(). To validate this theory, I've added atime.Sleep()at the beginning ofrun(): if you do it, the test always fail, while it shouldn't.Instead of adding a sleep in the test, in this PR I'm proposing to initialise
ringLastStatein thestarting()function, right after we've synched the config, which is actually more accurate.Which issue(s) this PR fixes:
Fixes #4229
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]