Use backoff functionality from github.com/grafana/dskit #4426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
changed the title
Signed-off-by: Arve Knudsen <[email protected]>
pracucci
approved these changes
Aug 18, 2021
pstibrany
approved these changes
Aug 18, 2021
|
When other libraries are upgraded, e.g. |
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
…t/cortex#4426) * Use dskit/backoff Signed-off-by: Arve Knudsen <[email protected]> * Fix formatting Signed-off-by: Arve Knudsen <[email protected]> * Remove changelog entry Signed-off-by: Arve Knudsen <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…t#4426) * Use dskit/backoff Signed-off-by: Arve Knudsen <[email protected]> * Fix formatting Signed-off-by: Arve Knudsen <[email protected]> * Remove changelog entry Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I propose to refactor to use dskit's
backoffpackage instead of pkg/util/backoff.go.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]