Skip to content

Update prometheus to v2.30.0 #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Sep 21, 2021

What this PR does:

Update prometheus to v2.30.0

Which issue(s) this PR fixes:

This supersedes #4437 edit: corrected number

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Christian Simon <[email protected]>
@simonswine simonswine force-pushed the 20210921_update-prometheus branch from 518bfcb to 77df722 Compare September 21, 2021 09:08
@simonswine simonswine marked this pull request as ready for review September 23, 2021 11:15
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bboreham
Copy link
Contributor

bboreham commented Oct 1, 2021

This supersedes #4473

That one is merged, did you mean a different number?

Note a couple of merge conflicts, also we like to call out key changes in the CHANGELOG (if any).

@bboreham
Copy link
Contributor

bboreham commented Oct 1, 2021

Changes I can see in the Prometheus code:

  • added present_over_time function
  • optional TSDB head snapshot on shutdown (possibly not exposed by Cortex?)
  • optimisations to speed up TSDB and use less memory

@pstibrany
Copy link
Contributor

Note that #4505 updated Prometheus to the same version, but it didn't integrate new features (snapshot on shutdown).

@bboreham
Copy link
Contributor

bboreham commented Oct 1, 2021

OK I'll do the changelog.

@simonswine
Copy link
Contributor Author

This supersedes #4473

@bboreham sorry, that was the wrong number #4437 is correct. Thanks for sorting out the CHANGELOG.md

@simonswine simonswine closed this Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants