Skip to content

Add a note about remote read in HA Pair handling #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

roidelapluie
Copy link
Contributor

Signed-off-by: Julien Pivotto [email protected]

What this PR does:
Add a note about remote read in HA Pair handling

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@roidelapluie
Copy link
Contributor Author

roidelapluie commented Sep 29, 2021

To be honest I am not sure where the fix lies - either this documentation fix, or cortex ignoring the __replica__ label on remote read endpoint, or Prometheus having an extra flag to ignore some labels in remote read.

@bboreham
Copy link
Contributor

bboreham commented Oct 1, 2021

cortex ignoring the __replica__ label on remote read endpoint

If HA is configured this would be reasonable; currently that config only applies to distributor but no great issue extending.

@stale
Copy link

stale bot commented Jan 1, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 1, 2022
@stale stale bot removed the stale label Jan 6, 2022
@bboreham bboreham merged commit 8011bfe into cortexproject:master Jan 6, 2022
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants