Skip to content

Reintroduce pkg/util/middleware, in place of dskit/middleware #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jan 13, 2022

What this PR does:
Reintroduce pkg/util/middleware, in place of dskit/middleware

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • [na] Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci enabled auto-merge (squash) January 13, 2022 14:23
@pstibrany
Copy link
Contributor

This needs a rebase now :(

auto-merge was automatically disabled January 13, 2022 14:30

Head branch was pushed to by a user without write access

@aknuds1 aknuds1 force-pushed the chore/reintroduce-middleware branch from 979c526 to 34a281e Compare January 13, 2022 14:30
@aknuds1
Copy link
Contributor Author

aknuds1 commented Jan 13, 2022

This needs a rebase now :(

@pstibrany done!

@pstibrany pstibrany enabled auto-merge (squash) January 13, 2022 14:54
@pstibrany
Copy link
Contributor

This needs a rebase now :(
@pstibrany done!

Thank you, enabled auto-merge.

@pstibrany
Copy link
Contributor

Oh no, there is another conflict not :-(

auto-merge was automatically disabled January 13, 2022 15:00

Head branch was pushed to by a user without write access

@aknuds1 aknuds1 force-pushed the chore/reintroduce-middleware branch from 34a281e to 692c641 Compare January 13, 2022 15:00
@pracucci pracucci merged commit c425c8b into cortexproject:master Jan 13, 2022
@aknuds1 aknuds1 deleted the chore/reintroduce-middleware branch January 13, 2022 17:06
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants