Skip to content

Add shuffle sharding grouper/planner (Clone of PR 4357) #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alvinlin123
Copy link
Contributor

@alvinlin123 alvinlin123 commented Jan 14, 2022

This is just a workbench to get #4357 merged.

Below is a copy from the original PR:

Signed-off-by: Albert [email protected]

What this PR does:

Implements generation of parallelize plans for the proposal outlined in #4272 using a shuffle sharding grouper and planner. Currently the parallelizable plans are generated but every compactor runs every planned compaction, the actual sharding will happen in a subsequent PR.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alvinlin123 alvinlin123 force-pushed the pr-4357-merge-work-bench branch from c76479a to 568d256 Compare January 14, 2022 21:30
Signed-off-by: Alvin Lin <[email protected]>
@alvinlin123 alvinlin123 changed the title Pr 4357 merge work bench Add shuffle sharding grouper/planner (PR 4357 merge workbench) Jan 14, 2022
@alvinlin123 alvinlin123 changed the title Add shuffle sharding grouper/planner (PR 4357 merge workbench) Add shuffle sharding grouper/planner (Clone of PR 4357) Jan 14, 2022
@alvinlin123
Copy link
Contributor Author

Since the original PR was reviewed and approved, I will go ahead and merge.

Copy link
Contributor

@nschad nschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test. Should I be able to approve here?! 👀

Edit: Ah you can but apparently you need write-access. I was worried for a sec, hehe

@alvinlin123
Copy link
Contributor Author

Test. Should I be able to approve here?! 👀

Edit: Ah you can but apparently you need write-access. I was worried for a sec, hehe

I was hoping your approval can allow me to merge :-), guess not.

@alvinlin123
Copy link
Contributor Author

Alright, we will use #4624 instead. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants