Remove support for chunks ingestion #4679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aughr
force-pushed
the
no_chunks_ingestion
branch
4 times, most recently
from
8dd0faf to
daf12a2
Compare
3 tasks
aughr
force-pushed
the
no_chunks_ingestion
branch
2 times, most recently
from
e8a2ef3 to
bd3bfea
Compare
Signed-off-by: Andrew Bloomgarden <[email protected]>
aughr
force-pushed
the
no_chunks_ingestion
branch
from
bd3bfea to
eade2a6
Compare
|
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
3 tasks
|
Closed by #4812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This removes support for chunks storage in the ingesters and defaults the engine storage to
blocks. Chunks storage is now only supported as a secondary store in the queriers.This also removes parts of chunk storage that were only accessible when run as the primary storage engine, notably the chunks series deletion purger. However, because we expect series deletion to come back in the future, e.g. via #4370 and beyond, this leaves the query-side tombstone stubs in place.
We discussed removing chunks storage in the last Americas-time community meeting in order to make it easier to maintain and improve Cortex. Based on some lightweight community polls in Slack and email, almost everyone has migrated to blocks storage, so I believe it is safe for us to start removing support for chunks storage entirely. The next step after this will be to remove support for querying chunks storage entirely, which we will likely want to put in a separate release from removing support in ingestion.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]