Add function to copy struct of amconfig.Config #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jml
approved these changes
Oct 31, 2017
|
I created this PR, which does the same thing: #590 @lelenanam 's PR looks nicer. @bboreham Any preference? |
|
My opinion is this solution is more robust and will work even if we add/change other fields of config or if fields are changing somewhere else in the code but we just haven't noticed it yet. |
bboreham
reviewed
Oct 31, 2017
pkg/alertmanager/multitenant.go
Outdated
| return newConfig, nil | ||
| } | ||
|
|
||
| func copyConfig(config *amconfig.Config) (*amconfig.Config, error) { |
There was a problem hiding this comment.
maybe add a comment explaining we need to do a deep copy because of pointers, slices, etc
Marshal/unmarshal json to deep copy config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshal/unmarshal json to deep copy config