Skip to content

Add native histogram query fuzz test #6654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SungJin1212
Copy link
Member

This PR adds a query fuzz test for the native histogram, It compares query result Cortex with the latest Prometheus.

Which issue(s) this PR fixes:
Fixes #6093

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the type/tests label Mar 18, 2025
@SungJin1212 SungJin1212 requested a review from yeya24 March 18, 2025 02:33
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it looks good. It would be nicer if we can generate both float and normal histograms

@SungJin1212 SungJin1212 marked this pull request as draft March 19, 2025 02:22
@SungJin1212 SungJin1212 force-pushed the Add-native-histogram-fuzz-test branch from d4a9c2c to afcdf33 Compare March 19, 2025 04:03
@SungJin1212 SungJin1212 marked this pull request as ready for review March 19, 2025 04:03
@SungJin1212
Copy link
Member Author

@yeya24
I added a comparer for the NH, and randomness.

@SungJin1212 SungJin1212 force-pushed the Add-native-histogram-fuzz-test branch from afcdf33 to fe07735 Compare March 19, 2025 04:09
@yeya24 yeya24 merged commit caf0a2f into cortexproject:master Mar 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query fuzz test for native histograms
2 participants