More ingester events #772
Merged
More ingester events #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't happen often enough to be meaningful.
This will make it possible to drill into the reasons for very short chunks.
This should make it possible to analyze which keys generate the most retries. Replaces the code which would log a few keys after all retries were exhausted.
bboreham
force-pushed
the
more-ingester-events
branch
from
fd5601f to
35ec19a
Compare
awh
approved these changes
Mar 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fleshing out the "event sampling" with more detail on chunks flushed, DynamoDB retries and series creation.
Also stop logging/eventing in the case where all retries are exhausted - this isn't useful if you sample all retries.
While I was in here I created a metric for chunks created - so you can see the rate of creation compared to the rate of flushing. Fixes #567