Refactor chunks-to-matrix code and its deps #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusv
force-pushed
the
refactor-matrix-code
branch
from
536f28d to
46e68c6
Compare
tomwilkie
reviewed
Nov 1, 2016
| return nil, err | ||
| } | ||
|
|
||
| ss.Values = util.MergeSamples(ss.Values, samples) |
There was a problem hiding this comment.
Merging lots of small lists into a large list will be n^2 in the worse case; ideally we'd to a merge-sort style tree merge. Not need to do it now, but file a ticket?
There was a problem hiding this comment.
Good point, could become a problem if we have many chunks for the same series. I filed #81
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #78...
This also gets rid of any
sort.Sortusage for merging&sorting incoming samples, which should be ok if we can assume that the samples in any chunks we read (as well as data from the ingesters) are already sorted. Then we just merge their samples together linearly, which includes deduplication.Since
MergeSamplesis now being used by different packages and there was no natural other home for it, I started autilpackage.