feat: backport unordered transactions #23708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
commented
Feb 14, 2025
| string memo = 2; | ||
| int64 timeout_height = 3; | ||
| uint64 some_new_field = 4; | ||
| uint64 some_new_field = 5; |
There was a problem hiding this comment.
…-unorderedtx-part-1
…-unorderedtx-part-1
Co-authored-by: yihuang <[email protected]> Co-authored-by: Facundo <[email protected]>
…-unorderedtx-part-1
…-unorderedtx-part-1
aljo242
reviewed
Feb 24, 2025
aljo242
reviewed
Feb 24, 2025
aljo242
reviewed
Feb 24, 2025
…-unorderedtx-part-1
technicallyty
changed the title
|
REMINDER TO SELF: Changelog for --
|
aljo242
reviewed
Feb 25, 2025
Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Alex | Interchain Labs <[email protected]>
…-unorderedtx-part-1
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aljo242
reviewed
Feb 26, 2025
proto/cosmos/tx/v1beta1/tx.proto
Outdated
| // incremented, which allows for fire-and-forget as well as concurrent | ||
| // transaction execution. | ||
| // | ||
| // Note, when set to true, the existing 'timeout_height' value must |
There was a problem hiding this comment.
This comment should be about timout_timestamp instead - needs to be reworked
will need to regen
There was a problem hiding this comment.
aljo242
approved these changes
Feb 26, 2025
…-unorderedtx-part-1
| import ( | ||
| fmt "fmt" | ||
| io "io" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import Note
aljo242
reviewed
Feb 27, 2025
…f ssh://github.com/cosmos/cosmos-sdk into technicallyty/backport-6ec53aaf54-unorderedtx-part-1
aljo242
approved these changes
Feb 27, 2025
technicallyty
deleted the
technicallyty/backport-6ec53aaf54-unorderedtx-part-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is the mega PR that will have all commits introduced for backporting the necessary work for unordered transactions.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...