-
Notifications
You must be signed in to change notification settings - Fork 4k
fix: tx compat #23850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tx compat #23850
Conversation
…-unorderedtx-part-1
…-unorderedtx-part-1
Co-authored-by: yihuang <[email protected]> Co-authored-by: Facundo <[email protected]>
…-unorderedtx-part-1
…-unorderedtx-part-1
…-unorderedtx-part-1
…-unorderedtx-part-1
Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Alex | Interchain Labs <[email protected]>
…-unorderedtx-part-1
…-unorderedtx-part-1
…-unorderedtx-part-1
…f ssh://github.com/cosmos/cosmos-sdk into technicallyty/backport-6ec53aaf54-unorderedtx-part-1
…cosmos/cosmos-sdk into technicallyty/23846/add-tx-compat
@technicallyty your pull request is missing a changelog! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should update the PR title and description since the TxBodyCompat type isn't actually needed anymore, right? It would be good to document the workaround and potential gotchas in detail in code comments in the relevant places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Closes: #23846
This PR fixes compatibility such that a v0.53 client can send transactions to v0.50 chains. It does so by ensuring that transaction builders (aux builder, etc) explicitly set
timestamppb.Timestamp
to nil when thetime.Time
value is the zero/default value.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...