Skip to content

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Feb 27, 2025

Description

Closes: #23846

This PR fixes compatibility such that a v0.53 client can send transactions to v0.50 chains. It does so by ensuring that transaction builders (aux builder, etc) explicitly set timestamppb.Timestamp to nil when the time.Time value is the zero/default value.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

technicallyty and others added 28 commits February 14, 2025 11:50
Co-authored-by: Facundo Medica <[email protected]>
Co-authored-by: Alex | Interchain Labs <[email protected]>
…f ssh://github.com/cosmos/cosmos-sdk into technicallyty/backport-6ec53aaf54-unorderedtx-part-1
@technicallyty technicallyty marked this pull request as ready for review March 8, 2025 04:12
@technicallyty technicallyty requested a review from a team March 8, 2025 04:12
Copy link
Contributor

github-actions bot commented Mar 8, 2025

@technicallyty your pull request is missing a changelog!

@aljo242 aljo242 requested a review from aaronc March 12, 2025 16:32
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should update the PR title and description since the TxBodyCompat type isn't actually needed anymore, right? It would be good to document the workaround and potential gotchas in detail in code comments in the relevant places

Copy link
Contributor

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@technicallyty technicallyty enabled auto-merge (squash) March 17, 2025 17:41
@technicallyty technicallyty merged commit c4ae99c into release/v0.53.x Mar 17, 2025
45 of 46 checks passed
@technicallyty technicallyty deleted the technicallyty/23846/add-tx-compat branch March 17, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants