Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 6, 2025

Description

TempDir returns a temporary directory for the test to use.The directory is automatically removed when the test and
all its subtests complete.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:

  • confirmed ! in the type prefix if API or client breaking change

  • targeted the correct branch (see PR Targeting)

  • provided a link to the relevant issue or specification

  • reviewed "Files changed" and left comments if necessary

  • included the necessary unit and integration tests

  • added a changelog entry to CHANGELOG.md

  • updated the relevant documentation or specification, including comments for documenting Go code

  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Tests
    • Streamlined internal test processes to simplify temporary directory management, enhancing maintainability without altering user-facing functionality.

This is an automatic backport of pull request #23893 done by [Mergify](https://mergify.com).

Co-authored-by: Tyler <[email protected]>
(cherry picked from commit 159bba1)

# Conflicts:
#	indexer/postgres/tests/init_schema_test.go
#	indexer/postgres/tests/postgres_test.go
@mergify mergify bot requested a review from a team March 6, 2025 15:46
@mergify mergify bot added the conflicts label Mar 6, 2025
Copy link
Contributor Author

mergify bot commented Mar 6, 2025

Cherry-pick of 159bba1 has failed:

On branch mergify/bp/release/v0.53.x/pr-23893
Your branch is up to date with 'origin/release/v0.53.x'.

You are currently cherry-picking commit 159bba145.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   x/genutil/collect_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   indexer/postgres/tests/init_schema_test.go
	deleted by us:   indexer/postgres/tests/postgres_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the C:x/genutil genutil module issues label Mar 6, 2025
@aljo242 aljo242 merged commit 1cf0c51 into release/v0.53.x Mar 6, 2025
55 checks passed
@aljo242 aljo242 deleted the mergify/bp/release/v0.53.x/pr-23893 branch March 6, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/genutil genutil module issues conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants