Skip to content

refactor(client): use map.Copy for cleaner map handling #24022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2025
Merged

refactor(client): use map.Copy for cleaner map handling #24022

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e870d27
optimize
petersssong Mar 17, 2025
14dbf7b
add generic_test
petersssong Mar 17, 2025
f0f39b6
fix linting
petersssong Mar 17, 2025
f7b55d2
add append to existing map case
petersssong Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions client/v2/autocli/flag/maps/generic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package maps

import (
"fmt"
"maps"
"strings"
)

Expand Down Expand Up @@ -44,9 +45,7 @@ func (gm *genericMapValue[K, V]) Set(val string) error {
if !gm.changed {
*gm.value = out
} else {
for k, v := range out {
(*gm.value)[k] = v
}
maps.Copy(*gm.value, out)
}
gm.changed = true
return nil
Expand Down
Loading