Skip to content

chore: slices Delete #24164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

chore: slices Delete #24164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb53c87
refactor: slices Delete
lido333 Mar 27, 2025
5b78de8
Merge branch 'release/v0.53.x' into feat/slice_delete
Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion types/mempool/sender_nonce.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"errors"
"fmt"
"math/rand" // #nosec // math/rand is used for random selection and seeded from crypto/rand
"slices"
"sync"

"github.com/huandu/skiplist"
Expand Down Expand Up @@ -307,5 +308,5 @@ func (i *senderNonceMempoolIterator) Tx() sdk.Tx {
}

func removeAtIndex[T any](slice []T, index int) []T {
return append(slice[:index], slice[index+1:]...)
return slices.Delete(slice, index, index+1)
}
5 changes: 3 additions & 2 deletions x/staking/types/delegation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package types

import (
"encoding/json"
"slices"
"strings"
"time"

Expand Down Expand Up @@ -159,7 +160,7 @@ func (ubd *UnbondingDelegation) AddEntry(creationHeight int64, minTime time.Time

// RemoveEntry - remove entry at index i to the unbonding delegation
func (ubd *UnbondingDelegation) RemoveEntry(i int64) {
ubd.Entries = append(ubd.Entries[:i], ubd.Entries[i+1:]...)
ubd.Entries = slices.Delete(ubd.Entries, int(i), int(i+1))
}

// return the unbonding delegation
Expand Down Expand Up @@ -251,7 +252,7 @@ func (red *Redelegation) AddEntry(creationHeight int64, minTime time.Time, balan

// RemoveEntry - remove entry at index i to the unbonding delegation
func (red *Redelegation) RemoveEntry(i int64) {
red.Entries = append(red.Entries[:i], red.Entries[i+1:]...)
red.Entries = slices.Delete(red.Entries, int(i), int(i+1))
}

// MustMarshalRED returns the Redelegation bytes. Panics if fails.
Expand Down
Loading