test: example upgrade handler and systems test #24182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
changed the title
Comment on lines
47
to
52
|
|
||
| modifications := [][]string{ | ||
| {"genesis", "add-genesis-account", v50CLI.AddKey("foo"), "10000000000stake"}, | ||
| {"genesis", "add-genesis-account", v50CLI.AddKey("bar"), "10000000000stake"}, | ||
| {"genesis", "add-genesis-account", v50CLI.AddKey("baz"), "10000000000stake"}, | ||
| } |
There was a problem hiding this comment.
lets add a comment here:
"typically, SystemUnderTest will create a node with 4 validators. In the legacy setup, we create run a single validator network. This means we need to add 3 more accounts in order to make further account additions map to the same account number in state."
Comment on lines
+114
to
+122
|
|
||
| t.Log("waiting for upgrade info") | ||
| systest.Sut.AwaitUpgradeInfo(t) | ||
| systest.Sut.StopChain() | ||
|
|
||
| t.Log("Upgrade height was reached. Upgrading chain") | ||
| systest.Sut.SetExecBinary(currentBranchBinary) | ||
| systest.Sut.SetTestnetInitializer(currentInitializer) | ||
| systest.Sut.StartChain(t) |
There was a problem hiding this comment.
can we assert that the correct height was reached? and that the new chain starts at upgradeHeight + 1?
There was a problem hiding this comment.
added assertion assert block height
|
i think |
aljo242
changed the title
technicallyty
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 24168