Skip to content

chore: fix dependency issues in v50.x #24930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 7, 2025

Description

Closes: #XXXX

@faddat faddat closed this Jul 7, 2025
@faddat faddat reopened this Jul 7, 2025
@mergify mergify bot mentioned this pull request Jul 7, 2025
@faddat faddat changed the title fix serious issues in v50.x chore: fix serious issues in v50.x Jul 7, 2025
@faddat
Copy link
Contributor Author

faddat commented Jul 7, 2025

CI doesn't work on the most widely used cosmos-sdk version?

@faddat faddat changed the title chore: fix serious issues in v50.x chore: fix dependency issues in v50.x Jul 7, 2025
@aljo242
Copy link
Contributor

aljo242 commented Jul 7, 2025

Thanks for opening this! We recommend chains update to v53 or manually update dependencies for cometbft

@faddat
Copy link
Contributor Author

faddat commented Jul 7, 2025

is v50 deprecated?

This is significantly larger than cometbft deps. Please re-review. I sent an email, about this.

Also I introduced a small bug/nit - some packages that didn't import cosmos-sdk before now do, I will change this over to draft.

@faddat faddat marked this pull request as draft July 7, 2025 19:26
@aljo242
Copy link
Contributor

aljo242 commented Jul 28, 2025

Going to close this for now - the path to using a fix of CometBFT will be using Cosmos SDK v0.53.x

@aljo242 aljo242 closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants