Skip to content

CXXCBC-482: Range scan orchestrator should use best effort retry strategy by default #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsej merged 2 commits into from
Mar 11, 2024
Merged

CXXCBC-482: Range scan orchestrator should use best effort retry strategy by default #542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ada5c6
CXXCBC-482: Range scan orchestrator should use best effort retry stra…
DemetrisChr Mar 11, 2024
9d6494f
Merge branch 'main' into CXXCBC-482
avsej Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/range_scan_orchestrator_options.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "range_scan_options.hxx"
#include "timeout_defaults.hxx"

#include <couchbase/best_effort_retry_strategy.hxx>
#include <couchbase/mutation_token.hxx>
#include <couchbase/retry_strategy.hxx>

Expand Down Expand Up @@ -51,7 +52,7 @@ struct range_scan_orchestrator_options {
std::uint32_t batch_byte_limit{ range_scan_continue_options::default_batch_byte_limit };
std::uint16_t concurrency{ default_concurrency };

std::shared_ptr<couchbase::retry_strategy> retry_strategy{ nullptr };
std::shared_ptr<couchbase::retry_strategy> retry_strategy{ make_best_effort_retry_strategy() };
std::chrono::milliseconds timeout{ timeout_defaults::key_value_scan_timeout };
std::shared_ptr<couchbase::tracing::request_span> parent_span{};
};
Expand Down