Skip to content

CXXCBC-503: Ignore configuration if it contains an empty vBucketMap #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thejcfactor merged 1 commit into from
Apr 9, 2024
Merged

CXXCBC-503: Ignore configuration if it contains an empty vBucketMap #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion core/bucket.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,19 @@ class bucket_impl
bool sequence_changed = false;
{
std::scoped_lock lock(config_mutex_);
if (!config_) {
if (config.vbmap && config.vbmap->size() == 0) {
if (!config_) {
CB_LOG_DEBUG("{} will not initialize configuration rev={} because config has an empty partition map",
log_prefix_,
config.rev_str());
} else {
CB_LOG_DEBUG("{} will not update the configuration old={} -> new={}, because new config has an empty partition map",
log_prefix_,
config_->rev_str(),
config.rev_str());
}
return;
} else if (!config_) {
CB_LOG_DEBUG("{} initialize configuration rev={}", log_prefix_, config.rev_str());
} else if (config.force) {
CB_LOG_DEBUG("{} forced to accept configuration rev={}", log_prefix_, config.rev_str());
Expand Down
4 changes: 4 additions & 0 deletions core/io/mcbp_session.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1256,6 +1256,10 @@ class mcbp_session_impl
return;
}
std::scoped_lock lock(config_mutex_);
if (config.vbmap && config.vbmap->size() == 0) {
CB_LOG_DEBUG("{} received a configuration with an empty vbucket map, ignoring", log_prefix_);
return;
}
if (config_) {
if (config_->vbmap && config.vbmap && config_->vbmap->size() != config.vbmap->size()) {
CB_LOG_DEBUG("{} received a configuration with a different number of vbuckets, ignoring", log_prefix_);
Expand Down