Skip to content

CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsej merged 3 commits into from
Apr 15, 2024
Merged

CXXCBC-30 Inconsistent behaviour when using subdoc opcodes incorrectly #559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dad6f5
Add test for mutate in request with lookup in specs
Matt-Woz Apr 15, 2024
1272fae
clang-format
Matt-Woz Apr 15, 2024
3b0bc62
Merge branch 'main' into CXXCBC-30_inconsistent_behaviour_with_subdoc…
Matt-Woz Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 34 additions & 17 deletions test/test_integration_subdoc.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,9 @@ assert_single_lookup_all_replica_success(test::utils::integration_test_guard& in
INFO(fmt::format("assert_single_lookup_all_replica_success(\"{}\", \"{}\")", id, req.specs[0].path_));
REQUIRE_SUCCESS(response.ctx.ec());
REQUIRE(response.entries.size() == integration.number_of_replicas() + 1);
auto responses_from_active =
std::count_if(response.entries.begin(), response.entries.end(), [](const auto& r) { return !r.is_replica; });
auto responses_from_active = std::count_if(response.entries.begin(), response.entries.end(), [](const auto& r) {
return !r.is_replica;
});
REQUIRE(responses_from_active == 1);
for (auto& resp : response.entries) {
REQUIRE_FALSE(resp.cas.empty());
Expand Down Expand Up @@ -181,8 +182,9 @@ assert_single_lookup_all_replica_error(test::utils::integration_test_guard& inte
INFO(fmt::format("assert_single_lookup_all_replica_error(\"{}\", \"{}\")", id, req.specs[0].path_));
REQUIRE_SUCCESS(response.ctx.ec());
REQUIRE(response.entries.size() == integration.number_of_replicas() + 1);
auto responses_from_active =
std::count_if(response.entries.begin(), response.entries.end(), [](const auto& r) { return !r.is_replica; });
auto responses_from_active = std::count_if(response.entries.begin(), response.entries.end(), [](const auto& r) {
return !r.is_replica;
});
REQUIRE(responses_from_active == 1);
for (auto& resp : response.entries) {
REQUIRE_FALSE(resp.cas.empty());
Expand Down Expand Up @@ -784,18 +786,31 @@ TEST_CASE("integration: subdoc multi lookup", "[integration]")

SECTION("mismatched type and opcode")
{
couchbase::core::operations::lookup_in_request req{ id };
req.specs =
couchbase::mutate_in_specs{
couchbase::mutate_in_specs::remove("array[0]"),
couchbase::mutate_in_specs::remove("array[0]"),
}
.specs();
auto resp = test::utils::execute(integration.cluster, req);
if (integration.cluster_version().is_mock()) {
REQUIRE(resp.ctx.ec() == couchbase::errc::common::unsupported_operation);
} else {
REQUIRE(resp.ctx.ec() == couchbase::errc::common::invalid_argument);
{
couchbase::core::operations::lookup_in_request req{ id };
req.specs =
couchbase::mutate_in_specs{
couchbase::mutate_in_specs::remove("array[0]"),
couchbase::mutate_in_specs::remove("array[0]"),
}
.specs();
auto resp = test::utils::execute(integration.cluster, req);
if (integration.cluster_version().is_mock()) {
REQUIRE(resp.ctx.ec() == couchbase::errc::common::unsupported_operation);
} else {
REQUIRE(resp.ctx.ec() == couchbase::errc::common::invalid_argument);
}
}
{
couchbase::core::operations::mutate_in_request req{ id };
req.specs =
couchbase::lookup_in_specs{ couchbase::lookup_in_specs::get("foo"), couchbase::lookup_in_specs::get("foo") }.specs();
auto resp = test::utils::execute(integration.cluster, req);
if (integration.cluster_version().is_mock()) {
REQUIRE(resp.ctx.ec() == couchbase::errc::common::unsupported_operation);
} else {
REQUIRE(resp.ctx.ec() == couchbase::errc::common::invalid_argument);
}
}
}

Expand Down Expand Up @@ -1310,7 +1325,9 @@ TEST_CASE("integration: subdoc all replica reads", "[integration]")
auto [ctx, result] = collection.lookup_in_all_replicas(key, specs).get();
REQUIRE_SUCCESS(ctx.ec());
REQUIRE(result.size() == number_of_replicas + 1);
auto responses_from_active = std::count_if(result.begin(), result.end(), [](const auto& r) { return !r.is_replica(); });
auto responses_from_active = std::count_if(result.begin(), result.end(), [](const auto& r) {
return !r.is_replica();
});
REQUIRE(responses_from_active == 1);
for (auto& res : result) {
REQUIRE(!res.cas().empty());
Expand Down