Skip to content

CXXCBC-690: Don't move staged_mutation item when capturing it in commit_doc lambdas #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsej merged 1 commit into from
May 30, 2025
Merged

CXXCBC-690: Don't move staged_mutation item when capturing it in commit_doc lambdas #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions core/transactions/staged_mutation.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -863,15 +863,13 @@ staged_mutation_queue::validate_commit_doc_result(const std::shared_ptr<attempt_
// TODO(SA): mutation tokens
const auto key = item.id().key();
ctx->hooks_.after_doc_committed_before_saving_cas(
ctx,
key,
[ctx, res, key, item = std::move(item), handler = std::move(handler)](auto ec) mutable {
ctx, key, [ctx, res, key, &item, handler = std::move(handler)](auto ec) mutable {
if (ec) {
return handler(client_error(*ec, "after_doc_committed_before_saving_cas threw error"));
}
item.cas(couchbase::cas{ res.cas });
return ctx->hooks_.after_doc_committed(
ctx, key, [item = std::move(item), handler = std::move(handler)](auto ec) mutable {
ctx, key, [handler = std::move(handler)](auto ec) mutable {
if (ec) {
return handler(client_error(*ec, "after_doc_committed threw error"));
}
Expand Down
Loading