Skip to content

CXXCBC-695: Always return unwrapped doc_exists from txns insert #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DemetrisChr merged 1 commit into from
Jun 3, 2025
Merged

CXXCBC-695: Always return unwrapped doc_exists from txns insert #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions core/transactions/attempt_context_impl.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,8 +1296,7 @@ attempt_context_impl::insert(const core::document_id& id,
self, "found existing insert or replace of {} while inserting", id);
return self->op_completed_with_error(
std::move(cb),
transaction_operation_failed(FAIL_DOC_ALREADY_EXISTS,
"found existing insert or replace of same document"));
document_exists("found existing insert or replace of same document"));
}
if (self->check_expiry_pre_commit(STAGE_INSERT, id.key())) {
return self->op_completed_with_error(
Expand Down Expand Up @@ -3694,9 +3693,7 @@ attempt_context_impl::create_staged_insert_error_handler(const core::document_id
if (doc->links().op() && *doc->links().op() != "insert") {
return self->op_completed_with_error(
std::forward<Handler>(cb),
transaction_operation_failed(FAIL_DOC_ALREADY_EXISTS,
"doc exists, not a staged insert")
.cause(DOCUMENT_EXISTS_EXCEPTION));
document_exists("doc exists, not a staged insert"));
}
self->check_and_handle_blocking_transactions(
*doc,
Expand Down
10 changes: 10 additions & 0 deletions core/transactions/exceptions.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,16 @@ public:
: op_exception(std::move(ctx), DOCUMENT_EXISTS_EXCEPTION)
{
}

explicit document_exists(transaction_op_error_context ctx, const std::string& what)
: op_exception(std::move(ctx), what, DOCUMENT_EXISTS_EXCEPTION)
{
}

explicit document_exists(const std::string& what)
: op_exception({ errc::transaction_op::document_exists }, what, DOCUMENT_EXISTS_EXCEPTION)
{
}
};

class query_attempt_not_found : public op_exception
Expand Down
Loading