CXXCBC-704: Return unwrapped document_unretrievable error from get_replica_from_preferred_server_group #782
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to the specification, the SDK shouldn't wrap
document_unretrievableerrors in atransaction_operation_failederror:Currently, we correctly don't cache the error internally, which allows users to 'catch' it, but we still wrap it in
transaction_operation_failed. The convention we must follow is thattransaction_operation_failedalways sets internal state and indicates the error cannot be handled to prevent a rollback.Change
When the replica get fails with
document_unretrievablereturn it without wrapping it in atransaction_operation_failederror.Results
Relevant FIT tests in
ExtReplicaFromPreferredServerGroupTestpass –docDoesNotExistandcanContinueAfterDocUnretrievable