Skip to content

Conversation

@DemetrisChr
Copy link
Contributor

Motivation

For transaction_operation_failed errors we rely on caching the error internally to be able to take action on it and commit/rollback the transaction, and return an appropriate overall error from the transaction. It must always be called with op_completed_with_error, otherwise the transaction will not properly fail.

Change

Move the feature_not_available TOF within cache_error_async and set it via op_completed_with_error.

Results

ExtReplicaFromPreferredGroupTest.cannotBeUsedAfterQueryMode FIT test now passes.

Copy link
Contributor

@thejcfactor thejcfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DemetrisChr DemetrisChr merged commit c38f565 into couchbase:main Sep 9, 2025
24 of 27 checks passed
@DemetrisChr DemetrisChr deleted the CXXCBC-721-txn-get-replica-fna branch September 9, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants