CXXCBC-721: Txns get replica - cache FeatureNotAvailable TOF #823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For
transaction_operation_failederrors we rely on caching the error internally to be able to take action on it and commit/rollback the transaction, and return an appropriate overall error from the transaction. It must always be called withop_completed_with_error, otherwise the transaction will not properly fail.Change
Move the
feature_not_availableTOF withincache_error_asyncand set it viaop_completed_with_error.Results
ExtReplicaFromPreferredGroupTest.cannotBeUsedAfterQueryModeFIT test now passes.