Skip to content

Improve stability of update collection max expiry tests #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avsej merged 1 commit into from
Sep 25, 2025
+3 −6
Merged

Improve stability of update collection max expiry tests #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions test/test_integration_management.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1633,9 +1633,8 @@ TEST_CASE("integration: collection management update collection with max expiry"
REQUIRE(test::utils::wait_until([&]() {
collection =
get_collection(integration.cluster, integration.ctx.bucket, scope_name, collection_name);
return collection.has_value();
return collection.has_value() && collection->max_expiry == 0;
}));
REQUIRE(collection->max_expiry == 0);
}

SECTION("positive max expiry")
Expand Down Expand Up @@ -1663,9 +1662,8 @@ TEST_CASE("integration: collection management update collection with max expiry"
REQUIRE(test::utils::wait_until([&]() {
collection =
get_collection(integration.cluster, integration.ctx.bucket, scope_name, collection_name);
return collection.has_value();
return collection.has_value() && collection->max_expiry == 3600;
}));
REQUIRE(collection->max_expiry == 3600);
}

SECTION("setting max expiry to no-expiry")
Expand Down Expand Up @@ -1694,9 +1692,8 @@ TEST_CASE("integration: collection management update collection with max expiry"
REQUIRE(test::utils::wait_until([&]() {
collection =
get_collection(integration.cluster, integration.ctx.bucket, scope_name, collection_name);
return collection.has_value();
return collection.has_value() && collection->max_expiry == -1;
}));
REQUIRE(collection->max_expiry == -1);
} else {
SECTION("core API")
{
Expand Down
Loading