Skip to content

Implement log wrappers for all versions of gocb and gocbcore #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2021
Merged

Implement log wrappers for all versions of gocb and gocbcore #5039

merged 3 commits into from
Jun 14, 2021

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Jun 11, 2021 •
edited
Loading

The test ensures that the values underneath the constants remain matching between packages and versions, which our log wrapper relies on.

@bbrks bbrks requested a review from adamcfraser June 11, 2021 15:59
@coveralls
Copy link

coveralls commented Jun 11, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 63.651% when pulling 66d09c7 on combine_gocb_loggers into 8605f78 on master.

@adamcfraser adamcfraser merged commit 63feeec into master Jun 14, 2021
@adamcfraser adamcfraser deleted the combine_gocb_loggers branch June 14, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcfraser adamcfraser adamcfraser approved these changes

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbrks @coveralls @adamcfraser