CBG-1901: Update ISGR/Blip to nhooyr.io/websocket #5421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrks
changed the title
bbrks
force-pushed
the
nhooyr-websocket
branch
2 times, most recently
from
59c56b7 to
236edd2
Compare
bbrks
force-pushed
the
nhooyr-websocket
branch
from
c3c4cca to
2582dfa
Compare
bbrks
force-pushed
the
nhooyr-websocket
branch
from
2582dfa to
eb7c94a
Compare
bbrks
commented
Feb 8, 2022
adamcfraser
approved these changes
Feb 14, 2022
gregns1
pushed a commit
that referenced
this pull request
Jan 26, 2023
* Update ISGR/Blip to nhooyr.io/websocket * Fix manifest path * Update manifest for couchbasedeps compress * Bump go-blip manifest
bbrks
added a commit
that referenced
this pull request
Jan 26, 2023
…6040) * CBG-2611: Update go-blip version, and add websocket library and compress library * Backport jenkinsfile updates to 2.8.3 (#5585) * Backport jenkinsfile fixes to 2.8.3 * Remove 3.0-specific config * fix manifest * updated errCheck version * updated go version version * updated go version version again * turn off go mod * updates to fix failiure on jenkins * CBG-2611: [2.8.4] Update ISGR/Blip to nhooyr.io/websocket (#5421) * Update ISGR/Blip to nhooyr.io/websocket * Fix manifest path * Update manifest for couchbasedeps compress * Bump go-blip manifest * fixed errors woth dependencies and cherry picked CBG-2607 as it was needed to allow the dependency changes * duplicate paths * fix for some test * test fixes + lite core skip * fix go vet Co-authored-by: Adam Fraser <[email protected]> Co-authored-by: Ben Brooks <[email protected]>
gregns1
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Update ISGR/Blip to nhooyr.io/websocket * Fix manifest path * Update manifest for couchbasedeps compress * Bump go-blip manifest
bbrks
added a commit
that referenced
this pull request
Jan 31, 2023
* CBG-2608: update websocket implementation * CBG-1901: Update ISGR/Blip to nhooyr.io/websocket (#5421) * Update ISGR/Blip to nhooyr.io/websocket * Fix manifest path * Update manifest for couchbasedeps compress * Bump go-blip manifest * CBG-2242: fix errors.As in tests (#5739) * errors as fix * Assert on typed x509 error first before macOS-specific fallback (#6011) Only falls back to macOS-specific x509 error assertion if the initial typed assertion failed. Fixes test failure when running with Go 1.20, 1.19.5 or 1.18.10 due to golang/go#56891 * missed dependency upgrades to json iterator, and reflect to stop panics --------- Co-authored-by: Ben Brooks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-1901
Replaces go-blip and ISGR
x/net/websocketimplementations withnhooyr.io/websocketTODO
Dependencies (if applicable)
couchbasedepsis updatedIntegration Tests
xattrs=truehttp://uberjenkins.sc.couchbase.com:8080/job/sync-gateway-integration/1576/