Updated to fix json stream bug in latest Pineapple Firmware. Updated … #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…README to better reflect how to use library.
…to methods. Need to rewrite pineapple module next
Closed
sundhaug92
reviewed
Sep 16, 2018
| </pre> | ||
| Returns a dict. The pool is on the key "ssidPool" separated by newlines. To get a quick list, do the following: | ||
| <pre> | ||
| ssids = p['ssidPool'].split('\n') |
There was a problem hiding this comment.
shouldn't p['ssidPool'] return a list instead of a '\n'-joined string?
There was a problem hiding this comment.
Yea probably but that's what's returned from the API raw. I've been using logging.getPineapLog() instead because it comes back structured with clients in json. I'll be publishing some more stuff and rewriting a bunch more of this library in my own repo as I get to it. I have to modify this PR most likely, as it wasn't backwards compatible with older firmware. The pineapple.api in mine is now but before submitting more PRs, I wanted to rewrite a few more things.
…some detail about what they do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…README to better reflect how to use library. This issue occured when trying to use the library against firmware 2.3.2. Was a simple fix.