-
Notifications
You must be signed in to change notification settings - Fork 39
feat(atomic): migrate atomic-smart-snippet-source to Lit #6821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
13
commits into
main
Choose a base branch
from
copilot/migrate-atomic-smart-snippet-source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: y-lakhdar <[email protected]>
Co-authored-by: y-lakhdar <[email protected]>
…rt-snippet-source Co-authored-by: y-lakhdar <[email protected]>
Copilot
AI
changed the title
[WIP] Migrate atomic-smart-snippet-source
feat(atomic): migrate atomic-smart-snippet-source to Lit
Dec 16, 2025
…com:coveo/ui-kit into copilot/migrate-atomic-smart-snippet-source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
.mdxfile - N/A for internal componentsindex.tsandlazy-index.tsfiles - Auto-registered via@customElementhttps://coveord.atlassian.net/browse/KIT-5063
Description
Migrated
atomic-smart-snippet-sourcefrom Stencil to Lit. This internal component renders source URL and title links for smart snippets across search and insight interfaces.Changes
Component Migration
LightDomMixinto match Stencil'sshadow: falseselectSource,beginDelayedSelectSource,cancelPendingSelectSource) now use Lit'sbuildCustomEventrenderLinkWithItemAnalyticsfunctional componentatomic/resolveResultreplaces Stencil's@Listendecoratoratomic-smart-snippet-source/with Stencil version preserved asstencil-atomic-smart-snippet-source.tsxTesting
15 unit tests covering initialization, rendering, event dispatch, result context, attribute application, and cleanup. No E2E or Storybook artifacts needed—internal component tested through parent smart-snippet components.
Technical Notes
Component serves as a child element in:
atomic-smart-snippet/atomic-smart-snippet-suggestions(search)atomic-insight-smart-snippet/atomic-insight-smart-snippet-suggestions(insight)HTMLElementTagNameMap declaration intentionally omitted to prevent type conflicts with Stencil-generated definitions during the migration period.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.