Coverlet.Collector.nuspec puts files in the wrong folder #431
Labels
Comments
|
I'm preparing a fix for these issues, which also eliminates the checked in nuspec file so that you don't have two files to maintain -- just the csproj. |
AArnott
added a commit
to AArnott/coverlet
that referenced
this issue
May 27, 2019
All the redundancy between the .nuspec file and the .csproj file (both express and implied) is now removed. With it, I fix a few bugs: 1. The generated nuspec file includes the developmentDependency tag that was in the project file but not the checked in file. 1. The package now applies to *all* projects regardless of their target framework (well, so long as they're .netstandard1.0 compatible) instead of all projects rejecting this package unless they targeted .NET Core 2.0 or higher. I also moved the .targets file into a folder structure within the project that resembles where it will appear in the package. This makes it more obvious that it belongs to the package when looking at the source code, and makes it easier to maintain the build/ folder in the package going forward because all files in it are included. Fixes coverlet-coverage#431
AArnott
added a commit
to AArnott/coverlet
that referenced
this issue
May 27, 2019
All the redundancy between the .nuspec file and the .csproj file (both express and implied) is now removed. With it, I fix a few bugs: 1. The generated nuspec file includes the developmentDependency tag that was in the project file but not the checked in file. 1. The package now applies to *all* projects regardless of their target framework (well, so long as they're .netstandard1.0 compatible) instead of all projects rejecting this package unless they targeted .NET Core 2.0 or higher. I also moved the .targets file into a folder structure within the project that resembles where it will appear in the package. This makes it more obvious that it belongs to the package when looking at the source code, and makes it easier to maintain the build/ folder in the package going forward because all files in it are included. Fixes coverlet-coverage#431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The checked in Coverlet.Collector.nuspec file is missing this tag:
which I'm guessing should be there since in fact it is present in the .csproj file, but not in the checked in nuspec file.
Also: all the files included in the package are placed under the
build\netcoreapp2.0folder, which will make the NuGet package only able to install into other .NET Core 2.0+ projects. But since this is a build authoring package, it probably can (and probably should?) apply to all kinds of projects. So the folder used should bebuild\netstandard1.0.The text was updated successfully, but these errors were encountered: