Skip to content

Complete IFileSystem injection #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoRossignoli opened this issue Sep 13, 2019 · 0 comments · Fixed by #550
Closed

Complete IFileSystem injection #543

MarcoRossignoli opened this issue Sep 13, 2019 · 0 comments · Fixed by #550
Labels
enhancement General enhancement request up-for-grabs Good issue for contributors

Comments

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Sep 13, 2019 •
edited
Loading

On PR #538 we added injection for file system access to allow testing.
For now we've implemented only Exists https://github.com/tonerdo/coverlet/blob/master/src/coverlet.core/Helpers/FileSystem.cs
Define and implement all other methods and apply on callers

cc: @tonerdo @petli
@MarcoRossignoli MarcoRossignoli added enhancement General enhancement request up-for-grabs Good issue for contributors labels Sep 13, 2019
@daveMueller daveMueller mentioned this issue Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement General enhancement request up-for-grabs Good issue for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SystemIOFile Adapter daveMueller/coverlet
1 participant
@MarcoRossignoli