Skip instrumentation for external pdb with no local sources #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
commented
Sep 10, 2019
| { | ||
| bool Exists(string path); | ||
| } | ||
| } |
There was a problem hiding this comment.
for the moment I wrapped only needed method
MarcoRossignoli
commented
Sep 10, 2019
| "aead64ad")] | ||
| // Needed to mock internal type https://github.com/Moq/moq4/wiki/Quickstart#advanced-features | ||
| [assembly: System.Runtime.CompilerServices.InternalsVisibleTo("DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7")] |
There was a problem hiding this comment.
to mock internal IFileSystem for testing we need to allow access from dynamic proxy, it's signed.
MarcoRossignoli
commented
Sep 10, 2019
| // We verify all docs and return false if not all are present in local | ||
| // We could have false negative if doc is not a source | ||
| // Btw check for all possible extension could be weak approach | ||
| if (!_fileSystem.Exists(docName)) |
There was a problem hiding this comment.
like embedded one we check for all docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #529
cc: @tonerdo @petli @onovotny