coverlet.collector is missing dependencies

[jdanielbioc]

Unlisted dependency on old version of FileSystemGlobbing is causing problems starting a project in built in 3.1.

Unhandled exception. System.IO.FileLoadException: Could not load file or assembly 'Microsoft.Extensions.FileSystemGlobbing, Version=3.1.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The located assembly's manifest definition does not match the assembly reference. (0x80131040)
File name: 'Microsoft.Extensions.FileSystemGlobbing, Version=3.1.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.ChangeTokenInfo..ctor
at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.ChangeTokenInfo..ctor(CancellationTokenSource tokenSource, CancellationChangeToken changeToken)
at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.GetOrAddFilePathChangeToken(String filePath)
at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.GetOrAddChangeToken(String pattern)
at Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.CreateFileChangeToken(String filter)
at Microsoft.Extensions.FileProviders.PhysicalFileProvider.Watch(String filter)
at Microsoft.Extensions.Configuration.FileConfigurationProvider.<.ctor>b__1_0()
at Microsoft.Extensions.Primitives.ChangeToken.ChangeTokenRegistration1..ctor(Func1 changeTokenProducer, Action1 changeTokenConsumer, TState state) at Microsoft.Extensions.Primitives.ChangeToken.OnChange(Func1 changeTokenProducer, Action changeTokenConsumer)
at Microsoft.Extensions.Configuration.FileConfigurationProvider..ctor(FileConfigurationSource source)
at Microsoft.Extensions.Configuration.Json.JsonConfigurationProvider..ctor(JsonConfigurationSource source)
at Microsoft.Extensions.Configuration.Json.JsonConfigurationSource.Build(IConfigurationBuilder builder)
at Microsoft.Extensions.Configuration.ConfigurationBuilder.Build()
at Microsoft.Extensions.Hosting.HostBuilder.BuildAppConfiguration()
at Microsoft.Extensions.Hosting.HostBuilder.Build()
at Bioclinica.ClinFeed.OrchestrationService.Program.Main(String[] args) in C:\agent-intg_work\51\s\OrchestrationService\Program.cs:line 14

[MarcoRossignoli]

Hi @jdanielbioc the issue is not clear to me, this exception seem unrelated to Coverlet, I mean coverlet instruments users asm before run test and restore those at the end, but it should skip non user asm, can you attach the command line you used to run test?
Can you attach also your csproj?
This is our hello word example for collectors https://github.com/tonerdo/coverlet/tree/master/Documentation/Examples/VSTest/HelloWorld

[jdanielbioc]

Marco, Sorry if I was unclear coverlet was in the test project as you suggested, but after publishing everything the main project was unable to run due to the old version of FileSystemGlobbing that coverlet had loaded into the test project. Regards, Jeremy From: Marco Rossignoli <notifications@github.com> Sent: Thursday, January 2, 2020 6:03 PM To: tonerdo/coverlet <coverlet@noreply.github.com> Cc: Daniel, Jeremy <Jeremy.Daniel@bioclinica.com>; Mention <mention@noreply.github.com> Subject: Re: [tonerdo/coverlet] coverlet.collector is missing dependencies (#672) Hi @jdanielbioc<https://github.com/jdanielbioc> the issue is not clear to me, this exception seem unrelated to Coverlet, I mean coverlet instruments users asm before run test, can you attach the command line you used to run test? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#672>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOFTS6RHC34RWH3IUXXDZA3Q3ZXAZANCNFSM4KCHE56Q>.

…

-- Confidentiality Notice: This e-mail transmission may contain confidential or legally privileged information that is intended only for the individual(s) or entity named in the e-mail address, or the individual(s) or entity reasonably understood to be the intended recipient via content or context of the transmission. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or reliance upon the contents of this e-mail is strictly prohibited. If you have received this e-mail transmission in error, please reply to the sender and then delete the message from your computer. Thank you. --

[MarcoRossignoli]

Can you attach you command line?
When you say publishing you mean dotnet publish and after dotnet vstest lib.dll?

[jdanielbioc]

We ran “dotnet clean” followed by “dotnet publish -o app/publish” at the level of the solution file. When the test project references coverlet.collector app/publish has the wrong version of the file globbing dll. We are not looking to fix that, just the incorrect display of dependencies on nuget.org which made it harder to track down this as the cause. JEREMY DANIEL SENIOR PRODUCT DEVELOPER Bioclinica 211 Carnegie Center Drive Princeton, New Jersey 08540 USA Based Remotely in Boston, MA, USA email  jeremy.daniel@bioclinica.com bioclinica.com

…

________________________________ From: Marco Rossignoli <notifications@github.com> Sent: Friday, January 3, 2020 4:12:08 PM To: tonerdo/coverlet <coverlet@noreply.github.com> Cc: Daniel, Jeremy <Jeremy.Daniel@bioclinica.com>; Mention <mention@noreply.github.com> Subject: Re: [tonerdo/coverlet] coverlet.collector is missing dependencies (#672) Can you attach you command line? When you say publishing you mean dotnet publish and after dotnet vstest lib.dll? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#672>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOFTS6VPJC6P6QYQRSRUERDQ36S2RANCNFSM4KCHE56Q>.

-- Confidentiality Notice: This e-mail transmission may contain confidential or legally privileged information that is intended only for the individual(s) or entity named in the e-mail address, or the individual(s) or entity reasonably understood to be the intended recipient via content or context of the transmission. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or reliance upon the contents of this e-mail is strictly prohibited. If you have received this e-mail transmission in error, please reply to the sender and then delete the message from your computer. Thank you. --

[MarcoRossignoli]

Yup when publishing all files are moved to target directory(also coverlet nuget package files) so globbing dll is overwrite. I'm wondering why you don't run test without publishing, only using dotnet test --collect:"XPlat Code Coverage" from root(where sln file is placed) or from test csproj folder, in this way Coverlet files are not copied to output and globbing dll shouldn't be overwrite. I mean publish test projects usually is done only to test with dotnet vstest ..dll and not to deploy to prod, so run test without "publish" should avoid the issue. It's not clear why you run app from test project (I mean the target folder of test project).

[MarcoRossignoli]

We are not looking to fix that, just the incorrect display of dependencies on nuget.org which made it harder to track down this as the cause.

You're right, unfortunatly coverlet is packed as build assets https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets because it runs before and after tests(imports props and target files) and is not consumed as a lib so nuget ui doesn't show any dependencies because all files are "embedded" and also because it's not a consumed "dependency" for the project is using it.
Btw if possible I advice to use dotnet test ... and not run dotnet publish/dotnet vstest ...dll so libs shouldn't be moved to target folder.

For now I'll tag as-designed, I'll do some search to understand if make sense/is possible document in some way from nuget.org site perspective, but for now I don't think that is possible because globbing lib is a reference of an internal(for now) core library(that is not present on nuget) coverlet.core.dll so also if we publish that dependency(no more private assets) you won't see Microsoft.Extensions.FileSystemGlobbing dep. Maybe in future when/if we'll publish core lib standalone we could expose all real deps.

Feel free to close if solved for the moment.