Skip to content

Consolidate drivers versions #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcoRossignoli opened this issue Jun 13, 2020 · 7 comments · Fixed by #971
Closed

Consolidate drivers versions #874

MarcoRossignoli opened this issue Jun 13, 2020 · 7 comments · Fixed by #971

Comments

@MarcoRossignoli
Copy link
Collaborator

Release workflow for coverlet is not simple due to different versions of drivers.
Now that we're ready to sign our package the things will be worse.
My proposal and after @clairernovotny's advice is to consolidate coverlet version since next release 3.0.0 to allow automatic sign/deploy from pipeline.
Sure, we have different features supported for different drivers, but we can document with a md.

Possible new release workflow:

  1. Move all version on master to x.x.x-preview.{height} and release on nightly release once a day if there are new commits.
  2. When release remove -preview.{height} create a release branch rel/vx.x.x where we fix the version on version.json of packages.
  3. Update pipeline to manual release a signed version to nuget directly from release branch.

@tonerdo can you enable master protection(merge only using PR)?So I can work using branch(no more fork) without fear 😄
@clairernovotny can you take a look at plan and give further advice if you see something wrong or improvable?

@MarcoRossignoli
Copy link
Collaborator Author

ping @tonerdo

@tonerdo
Copy link
Collaborator

tonerdo commented Jun 24, 2020

No idea how to enable branch protection. Any pointers?

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Jun 29, 2020

@tonerdo added protected branch for master https://github.com/coverlet-coverage/coverlet/settings/branches 1 approver no direct push allowed to master also for admin.
image

That said, do you agree on packages version alignment to 3.0 from next release?

@tonerdo
Copy link
Collaborator

tonerdo commented Jul 19, 2020

@MarcoRossignoli one question. What happens when we have to make a patch to a single driver, do we have to update the version numbers of the other drivers as well?

@MarcoRossignoli
Copy link
Collaborator Author

Yep, if we consolidate we'll lose the "per driver patch" and we should release all drivers every time we fix one.
This is the "only" drawaback.

@petli
Copy link
Collaborator

petli commented Sep 9, 2020

In case you're waiting on my opinion here and that stops progress on dotnet-foundation/projects#73, I think this all looks good.

@tonerdo
Copy link
Collaborator

tonerdo commented Sep 21, 2020

@MarcoRossignoli I'm willing to allow this since it better answers the question "What feature set of coverlet am I currently using?". Feel free to implement this in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants