-
Notifications
You must be signed in to change notification settings - Fork 388
Consolidate drivers versions #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
ping @tonerdo |
No idea how to enable branch protection. Any pointers? |
@tonerdo added protected branch for master https://github.com/coverlet-coverage/coverlet/settings/branches 1 approver no direct push allowed to master also for admin. That said, do you agree on packages version alignment to 3.0 from next release? |
@MarcoRossignoli one question. What happens when we have to make a patch to a single driver, do we have to update the version numbers of the other drivers as well? |
Yep, if we consolidate we'll lose the "per driver patch" and we should release all drivers every time we fix one. |
In case you're waiting on my opinion here and that stops progress on dotnet-foundation/projects#73, I think this all looks good. |
@MarcoRossignoli I'm willing to allow this since it better answers the question "What feature set of coverlet am I currently using?". Feel free to implement this in the next release |
Release workflow for coverlet is not simple due to different versions of drivers.
Now that we're ready to sign our package the things will be worse.
My proposal and after @clairernovotny's advice is to consolidate coverlet version since next release
3.0.0
to allow automatic sign/deploy from pipeline.Sure, we have different features supported for different drivers, but we can document with a md.
Possible new release workflow:
x.x.x-preview.{height}
and release on nightly release once a day if there are new commits.-preview.{height}
create a release branchrel/vx.x.x
where we fix the version onversion.json
of packages.@tonerdo can you enable master protection(merge only using PR)?So I can work using branch(no more fork) without fear 😄
@clairernovotny can you take a look at plan and give further advice if you see something wrong or improvable?
The text was updated successfully, but these errors were encountered: