Remove deterministic build feature hack for 3.1.300+ SDK

[MarcoRossignoli]

Ref issue #882 (comment)

[gitfool]

@MarcoRossignoli I'd also love to see this fixed and published in a stable version.

[clairernovotny]

You should be able to depend on InitializeSourceRootMappedPaths to return the SourceRoot items directly.
https://github.com/dotnet/roslyn/blob/c64d1e3a7b3e2b6d5a71ca4ceb5848bcd79a0970/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L186-L202

The target initially didn't return anything and in 3.1.300 it was changed to return those items.

[MarcoRossignoli]

Some notes for version checking https://github.com/novotnyllc/MSBuildSdkExtras/blob/master/Source/MSBuild.Sdk.Extras/Build/RIDs.targets#L145-L151

[MarcoRossignoli]

@gitfool pls can you try(tomorrow, we build at midnight) to test with nightly removing the workaround to confirm that with sdk >= 3.1.100 the workaround is not needed anymore? https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md

[gitfool]

@MarcoRossignoli it's now midnight (GMT) but I don't see a new preview for coverlet.collector. I guess I need to wait another day?

[MarcoRossignoli]

Oh issue with myget quota https://dev.azure.com/tonerdo/coverlet/_build/results?buildId=1197&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=7dae026f-9e99-5d65-075e-3f7579577f94 cc: @tonerdo can you cleanup all version older than last month?

@clairernovotny is there some unlimited nuget feed service provided by foundation?Or what is the most used way by other?Didn't check for a while are github package feats complete right now?

@gitfool I attach here master packages, move to a local folder and use it as nuget feed source.

preview.34.zip

[gitfool]

@MarcoRossignoli it works!

Specifically, I removed the Directory.Build.targets workaround so coverlet.collector 1.3.1-preview.27.gdd2237a3be reported no coverage; then I bumped it to 1.3.1-preview.34 via local NuGet source and it reported coverage as expected. 🎉