Skip to content

Stop coverlet clobbering dependencies #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ta264
Copy link

@ta264 ta264 commented Apr 27, 2021

Expose coverlet.core as a package, and pull in dependencies like a normal nuget package.

This stops coverlet clobbering dependencies on publish.

@@ -17,4 +16,24 @@
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
</ItemGroup>

<!-- Nuget package properties https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment we don't want to expose core lib as package, we discussed this one a lot of times, but for the moment we don't have a stable shape to expose. If we expose core as lib we want to do it in a proper stable way with a public "stable" contract.

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not ready to expose coverlet.core as standalone package yet.
Here you can find some discussion about it, but we didn't reach a mature time/reason to do it yet.
Maybe we could move on the discussion #212
Did also some experiment here #628

@ta264
Copy link
Author

ta264 commented May 4, 2021

Thanks for the comment. I don't really have a strong view about how this should be fixed but the current behaviour is pretty antisocial and should be changed in my opinion.

@MarcoRossignoli
Copy link
Collaborator

I'll keep this open for now as reminder of possibile solution. Thanks for the suggestion!

@MarcoRossignoli
Copy link
Collaborator

MarcoRossignoli commented Oct 29, 2021

Worked a bit on this one and maybe I found a way to avoid override without expose core #1243

thanks for your investigation/proposal here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants