-
Notifications
You must be signed in to change notification settings - Fork 389
Add project name to the CoverletSourceRootsMapping file to avoid file locking #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project name to the CoverletSourceRootsMapping file to avoid file locking #1320
Conversation
fb6dfa6
to
96e723b
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Can someone of the contributers or authors look why this PR can not get in (@tonerdo ?). |
I'm working on it, but I'm bit busy atm. |
You can dogfood the fix here for now #1155 (comment) something weird with CI... |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @MarcoRossignoli , so the issue is that after changing the tracker = asm.GetTypes().Single(n => n.FullName.Contains("Coverlet.Core.Instrumentation.Tracker")); The reason is that the tracker isn't injected (or not correct) into the assembly (coverlet.core.tests). It can't be found It's super weird that if changing the Any idea what could cause the tracker to not beeing injected into the assembly? |
But if we disable the coverage for our tests(we don't dogfood) does it work? |
Not I tried this and it didn't help. Basically every unit test that is using |
The issue is that |
closed here #1456 |
fixes #1155