Fix bug in the performance test and document how to run it in README.md. #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 16 16
Lines 1693 1693
=======================================
Hits 1613 1613
Misses 80 80Continue to review full report at Codecov.
|
tonerdo
reviewed
Nov 23, 2018
README.md
Outdated
|
|
||
| There is a performance test for the hit counting instrumentation in the test project `coverlet.core.performancetest`. Build the project with the msbuild step above and then run: | ||
|
|
||
| dotnet test -p:CollectCoverage=true test/coverlet.core.performancetest/ |
There was a problem hiding this comment.
Let's use the standard MSBuild /p
tonerdo
reviewed
Nov 23, 2018
| @@ -9,7 +9,7 @@ namespace coverlet.core.performancetest | |||
| /// Test the performance of coverlet by running a unit test that calls a reasonably big and complex test class. | |||
| /// Enable the test, compile, then run the test in the command line: | |||
| /// <code> | |||
| /// dotnet test -p:CollectCoverage=true -p:CoverletOutputFormat=opencover test/coverlet.core.performancetest/ | |||
| /// dotnet test -p:CollectCoverage=true test/coverlet.core.performancetest/ | |||
tonerdo
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug noticed while testing #241.