-
Notifications
You must be signed in to change notification settings - Fork 389
Restore backup assemblies when sigkill #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ViktorHofer let me understand better the case...if the "test process" is "interrupted" for some reason why recover?I mean if it's stopped will be eventually replaced by new build/test, isn't it? |
If you want to "safely" instrument assemblies - means the output should be exactly the same as before - a sigkill could cause big troubles here. We are hitting this in corefx whenever a coverage measurement takes too long and the user kills the process. We don't rebuild all the assemblies that we use during the measurement, i.e. CoreLib. But this isn't tied to corefx at all. Since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, unrelated comments on statics.
@tonerdo CI fail with some test on cecil tests...is it never happened before?It fails also on my local in |
@MarcoRossignoli taking a look now |
Is this ready to be merged? |
@ViktorHofer in future we'll remove that static #387 for now if it's a blocking issue LGTM cc: @tonerdo |
Yeah let's merge this first and ideally publish a new package first and afterwards do the refactoring. |
With sigkill or other execution interruptions the instrumented assemblies will remain in the output directory and the file backups won't be restored. Adding a cache to restore the backups in such cases.
cc @MarcoRossignoli @tonerdo