Skip to content

Skip switch symbol tests fail in "release mode" #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 2, 2019

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented May 1, 2019

closes #389
Temporary skip tests in release mode.

/cc @tonerdo @petli

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #390 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          16       16           
  Lines        2106     2106           
=======================================
  Hits         1835     1835           
  Misses        271      271

@MarcoRossignoli
Copy link
Collaborator Author

@tonerdo I tried to fix checking right line in release but it doesn't work...the issue raise only on Windows/Release

@MarcoRossignoli
Copy link
Collaborator Author

I did some test with Ubuntu 18.04 and I get same exception from release config...maybe we should use a different Ubuntu image on appveyor to get consistent behaviour Ubuntu1804 https://www.appveyor.com/updates/
VS 2019 will be available this month appveyor/ci#2907 (comment)

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented May 2, 2019

Another idea could be avoid to rely on "machine wide sdks" and download run/build/test with "specific" sdk in a xplat way https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script so we would have same "compiler", in my day-by-day work I'm used to do that.

@tonerdo
Copy link
Collaborator

tonerdo commented May 2, 2019

What version of Ubuntu does AppVeyor use by default?

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented May 2, 2019

We use Ubuntu https://github.com/tonerdo/coverlet/blob/master/appveyor.yml#L4 and from AppVeyor docs

Linux images:
Ubuntu or Ubuntu1604 - Ubuntu 16.04
Ubuntu1804 - Ubuntu 18.04

@tonerdo tonerdo merged commit 4ebe395 into coverlet-coverage:master May 2, 2019
@MarcoRossignoli MarcoRossignoli deleted the disabletests branch May 2, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch symbol tests fail in "release mode"
2 participants