Remove static Coverage object #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 13, 2019
MarcoRossignoli
force-pushed
the
removestatics2
branch
from
f7b3746 to
776a906
Compare
MarcoRossignoli
commented
May 13, 2019
| } | ||
|
|
||
| [TypeConverter(typeof(BranchKeyConverter))] | ||
| public class BranchKey : IEquatable<BranchKey> |
There was a problem hiding this comment.
Tuple is not serializable by json serializer.
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 86.98% 85.85% -1.13%
==========================================
Files 16 17 +1
Lines 2182 2234 +52
==========================================
+ Hits 1898 1918 +20
- Misses 284 316 +32 |
petli
approved these changes
May 13, 2019
tonerdo
approved these changes
May 13, 2019
Co-Authored-By: Toni Solarin-Sodara <[email protected]>
Co-Authored-By: Toni Solarin-Sodara <[email protected]>
|
@tonerdo PTAL thank's! |
This was referenced May 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #393 after Toni review feedback #393 (comment)
Keep old PR as useful notes.
/cc @tonerdo @vagisha-nidhi