[Bug fix]Fix "/p:UseSourceLink=true" bug #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
changed the title
|
Tested with @dbolin repro. Now file name point to correct repo root source file https://raw.githubusercontent.com/dbolin/Apex.Serialization/2582f069080a0b4291a2410c3d43f7c1ff3f6840/Binary.cs |
tonerdo
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #418
This PR https://github.com/tonerdo/coverlet/pull/299/files changed the way we build source link url.
In case of source is on repo root(special case) we need to skip relative path calculation.
cc: @tonerdo @dbolin
EDIT: now we have a nightly build (https://www.myget.org/F/coverlet-dev/api/v3/index.json) after merge we can ask to Dominic to try!