Inject InstrumentationHelper #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
commented
Sep 4, 2019
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| namespace Coverlet.Core | |||
| { | |||
| internal static class DependencyInjection | |||
| public static class DependencyInjection | |||
There was a problem hiding this comment.
The only thing I need to do is to expose container to be used by console/task/collector without expose internal implementation.
MarcoRossignoli
commented
Sep 4, 2019
| { | ||
| DependencyInjection.Current.GetService<IProcessExitHandler>().Add((s, e) => RestoreOriginalModules()); | ||
| processExitHandler.Add((s, e) => RestoreOriginalModules()); |
There was a problem hiding this comment.
@ViktorHofer you did this change, now a single instance of InstrumentationHelper will be returned by "static" container(singleton) so the delegate will keep object alive for "restore".
Is it ok for you or do you see some issue with it?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on #529 and I need to inject an IFilesystem service to instrumentation helper so simulate a missing source files.
To do that I need to move InstrumentationHelper class from static to instance, in this way we can also test a core part o coverlet, the instrumentation helper.
contributes also to #387
cc: @tonerdo @petli