Improve exception message #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
Update fork
Update fork
Update fork
Update fork
Update fork
|
|
src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs
Outdated
Show resolved
Hide resolved
src/coverlet.collector/DataCollection/CoverletCoverageCollector.cs
Outdated
Show resolved
Hide resolved
| @@ -165,15 +165,33 @@ private void OnSessionEnd(object sender, SessionEndEventArgs e) | |||
| /// <returns>Test modules list</returns> | |||
| private IEnumerable<string> GetTestModules(SessionStartEventArgs sessionStartEventArgs) | |||
| { | |||
| var testModules = sessionStartEventArgs.GetPropertyValue<IEnumerable<string>>(CoverletConstants.TestSourcesPropertyName); | |||
| if (_eqtTrace.IsInfoEnabled) | |||
| IEnumerable<string> testModules; | |||
There was a problem hiding this comment.
why not
private IEnumerable<string> GetTestModules(SessionStartEventArgs sessionStartEventArgs)
{
try
{
IEnumerable<string> testModules = GetPropertyValueWrapper(sessionStartEventArgs);
if (_eqtTrace.IsInfoEnabled)
{
_eqtTrace.Info("{0}: TestModules: '{1}'",
CoverletConstants.DataCollectorName,
string.Join(",", testModules ?? Enumerable.Empty<string>()));
}
return testModules;
}
catch (MissingMethodException ex)
{
throw new MissingMethodException("Make sure to use .NET core SDK Version >= 2.2.300", ex);
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #459