-
Notifications
You must be signed in to change notification settings - Fork 389
Add support for deterministic build for msbuild driver #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for deterministic build for msbuild driver #796
Conversation
Where is There'll need to be a doc update that tells people they'll need that in their |
Is imported here https://github.com/tonerdo/coverlet/pull/796/files#diff-56f8482aeb786dd105fbf93dedf2615f
Yes it's the last point in the list #363 (comment) I'll add samples for msbuild and collector here https://github.com/tonerdo/coverlet/blob/master/Documentation/Examples.md before release package. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@clairernovotny @tmat let me know if the translation alg and props/targets are ok to you and I'll take another review round and after I'll merge and I'll go ahead with the todo list. |
@clairernovotny tomorrow if you want you can try with nightly build, it's the most "official" after nuget release https://github.com/tonerdo/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md |
contributes to #363
@clairernovotny @tmat @tonerdo the main files to check are:
DeterministicBuild.targets -> workaround
src/coverlet.core/Helpers/SourceRootTranslator.cs -> path translator
test/coverlet.core.tests/Helpers/SourceRootTranslatorTests.cs -> tests
src/coverlet.msbuild.tasks/coverlet.msbuild.targets -> target for tests project
All other updates are tests fix and DI container update.