Change CecilSymbolHelper to instance class #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
Update fork
MarcoRossignoli
requested changes
May 14, 2020
MarcoRossignoli
requested changes
May 23, 2020
| { | ||
| // Create single instance, we cannot collide because we use full method name as key | ||
| CompilerGeneratedBranchesToExclude = new ConcurrentDictionary<string, int[]>(); | ||
| _compilerGeneratedBranchesToExclude = new ConcurrentDictionary<string, int[]>(); |
There was a problem hiding this comment.
We can initialize inline and remove ctor, before we wanted to be sure single thread initialization, now we use an singleton instance so no double init issue. Keep the comment above pls.
src/coverlet.console/Program.cs
Outdated
| @@ -88,7 +90,8 @@ static int Main(string[] args) | |||
| logger, | |||
| serviceProvider.GetService<IInstrumentationHelper>(), | |||
| fileSystem, | |||
| sourceTranslator); | |||
| sourceTranslator, | |||
There was a problem hiding this comment.
can we use serviceProvider.GetRequiredService everywhere where we don't use variable for more than one place?I see some assignation above, sourceTranslator is used in more than one place?
MarcoRossignoli
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #774